16442: Unable to use string with "on" in theme option label

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16442	Bug reports	Theme editor	public	2020-07-01 09:51	2020-10-19 10:13

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	4.3.2

Summary	16442: Unable to use string with "on" in theme option label
Description	In theme config : if you try to use 'on' string on some label it was translated to Yes directly. Even for none or contrast for example
Steps To Reproduce	Import https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla or https://dl.sondages.pro/skelvanilla.zip Install in 4.X For Survey : since it take parent see screen
Additional Information	Issue here : https://github.com/LimeSurvey/LimeSurvey/blob/67053bb60910b811e488a89ace7562442a8ae8ba/application/models/TemplateConfiguration.php#L1584-L1592 Must check if It's a label (here apply to any option) Only for $value === 'on' not inside But more : translation must come from Theme , not from core. No way for Theme to really translate.
Tags	No tags attached.
Attached Files	Capture d’écran du 2020-07-01 09-43-59.png (34,636 bytes) Capture d’écran du 2020-07-01 09-43-59.png (34,636 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	4.3.2 github
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	not relevant
Server OS (if known)	not relevant
Webserver software & version (if known)	not relevant
PHP Version	not relevant

User List	There are no users monitoring this issue.

DenisChenu 2020-07-01 16:14 developer ~58621	https://github.com/LimeSurvey/LimeSurvey/pull/1460

ollehar 2020-07-15 12:20 administrator ~58953	Hey Denis, can you be a little bit more precise in "Steps To Reproduce" so our QA-team can reproduce it? Thank you!

DenisChenu 2020-07-15 12:32 developer ~58954	Import https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla or https://dl.sondages.pro/skelvanilla.zip Since core theme didn't use this function : need a updated theme. In fact : it's the major issue, the function is not used by core, only for user theme. Then : it broke user theme, not core theme … global-skelvanilla.png (73,855 bytes) global-skelvanilla.png (73,855 bytes) survey-skelvanilla.png (61,915 bytes) survey-skelvanilla.png (61,915 bytes)

DenisChenu 2020-07-15 12:33 developer ~58955	Since gifyu image didn't work https://gifyu.com/image/QZDF

DenisChenu 2020-07-25 11:02 developer ~59087	In fact : never transform any string … https://hitchdev.com/strictyaml/why/implicit-typing-removed/

DenisChenu 2020-09-29 16:05 developer ~59984	@cdorin : you can assign someone to this bug ? Pull request is ready, when assigned : i update (it's only a remove uneeded and unused function)

DenisChenu 2020-10-19 07:25 developer ~60249	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30615

lime_release_bot 2020-10-19 10:13 administrator ~60256	Fixed in Release 4.3.22+201019

LimeSurvey: master 0e712755 2020-10-19 09:25 DenisChenu Committer: GitHub Details Diff	Fixed issue 16442: Unable to use string with "on" in theme option label (#1626) Dev: User theme options must not be update totally like this Dev: New settings already use optionlabels Dev: just in case …	Affected Issues 16442
	mod - application/controllers/admin/themeoptions.php	Diff File
	mod - application/models/TemplateConfiguration.php	Diff File

Date Modified	Username	Field	Change
2020-07-01 09:51	DenisChenu	New Issue
2020-07-01 09:51	DenisChenu	File Added: Capture d’écran du 2020-07-01 09-43-59.png
2020-07-01 10:02	DenisChenu	Summary	Unable to use string with "on" in label => Unable to use string with "on" in theme option label
2020-07-01 16:14	DenisChenu	Note Added: 58621
2020-07-15 12:20	ollehar	Note Added: 58953
2020-07-15 12:20	ollehar	Status	new => feedback
2020-07-15 12:32	DenisChenu	Note Added: 58954
2020-07-15 12:32	DenisChenu	File Added: global-skelvanilla.png
2020-07-15 12:32	DenisChenu	File Added: survey-skelvanilla.png
2020-07-15 12:32	DenisChenu	Status	feedback => new
2020-07-15 12:33	DenisChenu	Note Added: 58955
2020-07-21 15:18	DenisChenu	Severity	minor => partial_block
2020-07-25 11:02	DenisChenu	Note Added: 59087
2020-09-29 16:05	DenisChenu	Note Added: 59984
2020-10-19 07:25	DenisChenu	Changeset attached	=> LimeSurvey master 0e712755
2020-10-19 07:25	DenisChenu	Note Added: 60249
2020-10-19 07:25	DenisChenu	Assigned To	=> DenisChenu
2020-10-19 07:25	DenisChenu	Resolution	open => fixed
2020-10-19 10:13	lime_release_bot	Note Added: 60256
2020-10-19 10:13	lime_release_bot	Status	new => closed